Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force UTF-8 for all Javadoc tasks #940

Merged

Conversation

SamCarlberg
Copy link
Member

Will also now fail on error

Will also now fail on error
@codecov-io
Copy link

Codecov Report

Merging #940 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #940      +/-   ##
============================================
- Coverage     52.91%   52.89%   -0.03%     
  Complexity        1        1              
============================================
  Files           327      327              
  Lines          8852     8852              
  Branches        560      560              
============================================
- Hits           4684     4682       -2     
- Misses         3965     3966       +1     
- Partials        203      204       +1

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A drop in code coverage by -0.03%! How dare you?!

JK.

LGTM!

@SamCarlberg SamCarlberg merged commit 8c9afad into WPIRoboticsProjects:master Apr 20, 2019
@SamCarlberg SamCarlberg deleted the fix/aggregate-docs branch April 20, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants