Use CS Core Raw Streams for HTTPCamera Input #952

ThadHouse · 2019-10-19T22:59:44Z

The images are grabbed in native code, so they are much more efficient.
Also, the code is shared with all WPILib tools, so likely tested a bit more.

This also updates to the 2020 artifactory locations for dependencies, as they are needed for the raw CV stream support.

Outputs can be added in the future easily as well.

HTTP support works on all 3 platforms, it's only USB camera support that is limited.

The images are grabbed in native code, so they are much more efficient. Also, the code is shared with all WPILib tools, so likely tested a bit more

Needed repo grouping, which needed gradle 5.1 at minimum.

codecov-io · 2019-10-21T21:39:44Z

Codecov Report

Merging #952 into master will decrease coverage by 0.32%.
The diff coverage is 12.67%.

@@             Coverage Diff              @@
##             master     #952      +/-   ##
============================================
- Coverage     52.87%   52.55%   -0.33%     
  Complexity        1        1              
============================================
  Files           329      331       +2     
  Lines          8892     8968      +76     
  Branches        561      569       +8     
============================================
+ Hits           4702     4713      +11     
- Misses         3985     4049      +64     
- Partials        205      206       +1

JLLeitschuh · 2019-10-22T17:41:28Z

ui/src/test/java/edu/wpi/grip/ui/pipeline/AddSourceButtonTest.java

@@ -93,6 +94,7 @@ public void testClickOnCreateNetworkTableOpensDialog() throws Exception {
    }

    @Test
+    @Ignore("Fails on all platforms") // TODO: Figure out why this is broken.


At minimum, please at least ensure that this actually works when driven from the actual UI.
Same with the one below.

I don't know enough about the UI to know what this test even does? Do you know?

The test is failing because adding a webcam source is broken.

You can recreate this bug by running the GRIP UI and selecting "Add Source" -> "Webcam". Select your camera (on my computer this is 0). And press OK. GRIP will crash with a JVM error.

Process 'command '/Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home/bin/java'' finished with non-zero exit value 134

JLLeitschuh · 2019-10-22T17:42:14Z

ui/ui.gradle.kts

+    * jpackage, which is not ideal given that Java 13 is not yet stable.
+    *
+    * This task regenerates the jlink image every time it is invoked.
+    */


Nit: Comment formatting

JLLeitschuh · 2019-10-22T17:42:50Z

ui/ui.gradle.kts

@@ -349,7 +338,8 @@ fun JpackageExec.configureForCurrentOs() {
        OperatingSystem.LINUX -> {
            val installerFileDir = installerFilesBaseDir.resolve("linux")
            resourceDir.set(installerFileDir)
-            icon.set(installerFileDir.resolve("GRIP.png"))
+            // Skip icon on linux, causing build to break
+            //icon.set(installerFileDir.resolve("GRIP.png"))


Think you can figure it out/fix it?

I don't have a linux system, so my only testing is on Azure, which is basically impossible to fix. Would need someone else to test it and figure out whats happening.

I think its a bug in the j14 jpackager.

Using custom package resource [menu icon] (loaded from GRIP.png). java.nio.file.FileAlreadyExistsException: /tmp/jdk.jpackage13600112042171272034/images/opt/grip/lib/GRIP.png at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:94) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116) at java.base/sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:219) at java.base/java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:478) at java.base/java.nio.file.Files.newOutputStream(Files.java:223) at java.base/java.nio.file.Files.copy(Files.java:3143) at jdk.jpackage/jdk.jpackage.internal.AbstractBundler.fetchResource(AbstractBundler.java:94) at jdk.jpackage/jdk.jpackage.internal.LinuxPackageBundler$DesktopIntegration.prepareSrcIconFile(LinuxPackageBundler.java:771) at jdk.jpackage/jdk.jpackage.internal.LinuxPackageBundler$DesktopIntegration.create(LinuxPackageBundler.java:432) at jdk.jpackage/jdk.jpackage.internal.LinuxPackageBundler.execute(LinuxPackageBundler.java:177) at jdk.jpackage/jdk.jpackage.internal.Arguments.generateBundle(Arguments.java:627) at jdk.jpackage/jdk.jpackage.internal.Arguments.processArguments(Arguments.java:513) at jdk.jpackage/jdk.jpackage.main.Main.execute(Main.java:98) at jdk.jpackage/jdk.jpackage.main.Main.main(Main.java:51) jdk.jpackage.internal.PackagerException: java.nio.file.FileAlreadyExistsException: /tmp/jdk.jpackage13600112042171272034/images/opt/grip/lib/GRIP.png

Its failing to copy the icon file to the temp folder, but I can't find anywhere where its already being copied.

JLLeitschuh · 2019-10-22T17:43:07Z

Nice work @ThadHouse!

AustinShalit · 2019-10-23T04:24:40Z

ui/src/test/java/edu/wpi/grip/ui/pipeline/AddSourceButtonTest.java

@@ -93,6 +94,7 @@ public void testClickOnCreateNetworkTableOpensDialog() throws Exception {
    }

    @Test
+    @Ignore("Fails on all platforms") // TODO: Figure out why this is broken.


The test is failing because adding a webcam source is broken.

You can recreate this bug by running the GRIP UI and selecting "Add Source" -> "Webcam". Select your camera (on my computer this is 0). And press OK. GRIP will crash with a JVM error.

Process 'command '/Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home/bin/java'' finished with non-zero exit value 134

ThadHouse · 2019-10-23T18:25:56Z

I fixed the comments I knew how to fix. I don't know enough JavaFX to fix the failing tests, but theyre unrelated to this PR anyway.

The reason they had to be reenabled was we now build cscore and ntcore with Java 11, which means the Java 8 test method no longer works.

ThadHouse · 2019-10-23T18:31:41Z

It looks like the failing tests are even broken in Master. This PR just enables the tests on Java 11, which is why we're seeing them now.

JLLeitschuh · 2019-10-24T16:00:02Z

@SamCarlberg I'd really appreciate if you could take a look at these.

This reverts commit 05ad8bb.

ThadHouse · 2019-10-28T19:05:13Z

@JLLeitschuh I reverted the changes from this PR other then the ones to reenable tests, and they still fail. That means the tests are failing in master, and not just because of the changes in this PR. I want to start another PR building on top of this, any chance we can merge it and create an issue to address the failing tests? Based on the test descriptions, what I think they're testing works just fine, and its something wrong with the tests themselves. I can't figure out at all what is though.

https://dev.azure.com/wpiroboticsprojects/GRIP/_build/results?buildId=167

JLLeitschuh · 2019-10-28T20:49:01Z

@AustinShalit Thoughts? I'm okay as long as someone will follow up and resolve this soon.

AustinShalit · 2019-10-29T14:45:06Z

I would merge it.

JLLeitschuh

LGTM!

He approved it

ThadHouse added 28 commits October 19, 2019 15:58

Use CS Core Raw Streams for HTTPCamera Input

fb0d4d1

The images are grabbed in native code, so they are much more efficient. Also, the code is shared with all WPILib tools, so likely tested a bit more

Add missing osx deps

b699cea

Add release openjdk 13

d4f1e68

Fix checkstyle

93ce6e7

Fix private things

2f10e7c

More PMD Fixes

e22e205

Suppress spotbugs warnings

842dfe4

Fix opencv built version

52988ce

Revert to opencv 3.1

07f84cc

Needed repo grouping, which needed gradle 5.1 at minimum.

Revert back to 5.1

f5d7c20

JDK 13 things

4b433c3

Java 14 prerelease

a28c176

Fix jpackage

a2979fb

Fix jpackage again

6f70334

More changes

8414a3e

More things

acc4c4c

More args

1b9f238

Package type

8c179b2

More jpck

91ec57d

Finally fix jpkg

5d1d367

Jpackage 32 bit

4ca5075

Fix ran usage win32

083bbda

A few more good men

68c9e6b

Incorperate j11 tests

fe30d8c

Fix checkstyle issues

631d586

Fix wrapper

78a9dc1

Fix automatically generated tests

17f0a77

Skip failing tests

5ad617a

Skip UI tests on windows builds

5158039

Replace references to Java 13 with Java 14

624d1c9

JLLeitschuh reviewed Oct 22, 2019

View reviewed changes

AustinShalit previously requested changes Oct 23, 2019

View reviewed changes

Fix comments

5c36f7b

JLLeitschuh requested a review from SamCarlberg October 24, 2019 15:59

Revert change to check master tests

05ad8bb

ThadHouse force-pushed the rawcvstream branch from aa1e97a to 05ad8bb Compare October 28, 2019 18:41

Revert "Revert change to check master tests"

14d6986

This reverts commit 05ad8bb.

JLLeitschuh approved these changes Oct 29, 2019

View reviewed changes

JLLeitschuh merged commit 8923d10 into WPIRoboticsProjects:master Oct 29, 2019

This was referenced Oct 29, 2019

Upgrade tests to Java 11 only #953

Closed

Fix failing AddSourceButton Tests #954

Open

Crash while grabbing from cscore #862

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use CS Core Raw Streams for HTTPCamera Input #952

Use CS Core Raw Streams for HTTPCamera Input #952

ThadHouse commented Oct 19, 2019

codecov-io commented Oct 21, 2019 •

edited

Loading

JLLeitschuh Oct 22, 2019

ThadHouse Oct 22, 2019

AustinShalit Oct 23, 2019

JLLeitschuh Oct 22, 2019

JLLeitschuh Oct 22, 2019

ThadHouse Oct 22, 2019

ThadHouse Oct 22, 2019

JLLeitschuh commented Oct 22, 2019

AustinShalit Oct 23, 2019

ThadHouse commented Oct 23, 2019

ThadHouse commented Oct 23, 2019

JLLeitschuh commented Oct 24, 2019

ThadHouse commented Oct 28, 2019

JLLeitschuh commented Oct 28, 2019

AustinShalit commented Oct 29, 2019

JLLeitschuh left a comment

Use CS Core Raw Streams for HTTPCamera Input #952

Use CS Core Raw Streams for HTTPCamera Input #952

Conversation

ThadHouse commented Oct 19, 2019

codecov-io commented Oct 21, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLLeitschuh commented Oct 22, 2019

Choose a reason for hiding this comment

ThadHouse commented Oct 23, 2019

ThadHouse commented Oct 23, 2019

JLLeitschuh commented Oct 24, 2019

ThadHouse commented Oct 28, 2019

JLLeitschuh commented Oct 28, 2019

AustinShalit commented Oct 29, 2019

JLLeitschuh left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 21, 2019 •

edited

Loading