Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced the deprecated FILTER_SANITIZE_STRING with sanitize_text_field #388

Merged
merged 3 commits into from
Nov 18, 2023
Merged

Replaced the deprecated FILTER_SANITIZE_STRING with sanitize_text_field #388

merged 3 commits into from
Nov 18, 2023

Conversation

reygcalantaol
Copy link
Collaborator

@reygcalantaol reygcalantaol commented Nov 5, 2023 •
edited by wp-user-manager
Loading

Resolves #387
Resolves #358

Description

Replaced the deprecated FILTER_SANITIZE_STRING with sanitize_text_field

Testing Instructions

Pre-review Checklist

  • Issue and pull request titles are properly formatted.
  • Acceptance criteria have been satisfied and marked in the related issue.
  • Unit tests are included (if applicable).
  • Self-review of code changes has been completed.
  • Self-review of UX changes has been completed.
  • Review has been requested from @polevaultweb.

@wp-user-manager wp-user-manager mentioned this pull request Nov 5, 2023
Closed
6 tasks
@wp-user-manager
Copy link
Collaborator

@reygcalantaol thanks for this. However, the new changes break PHP coding standards, (see vendor/bin/phpcs in the README.md)

I think we still need to run the code through filter_input like in #372 first, before the sanitize function.

@wp-user-manager wp-user-manager merged commit 8a2456a into develop Nov 18, 2023
1 check failed
@wp-user-manager wp-user-manager deleted the #387-Deprecation-warning-in-2.9.7---Deprecated-Constant-FILTER_SANITIZE_STRING branch November 18, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning in 2.9.7 - Deprecated: Constant FILTER_SANITIZE_STRING Test and fix PHP 8.2 issues
3 participants
@reygcalantaol @wp-user-manager @polevaultweb