Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add additional factory methods to Kinesis to create Akka Source #61

Merged
merged 5 commits into from
Apr 23, 2018

Conversation

htimur
Copy link
Contributor

@htimur htimur commented Apr 20, 2018

As the result of the issue with graceful shutdown of the KinesisConsumer described in #60, I added the additional methods to create the Akka Source with explicitly pathing the ConsumerService, for the better controll of the shutdown process.

…tream source with explicitly specifying ConsumerService
@markglh
Copy link
Contributor

markglh commented Apr 20, 2018

Thanks for this!

It's weird that this isn't firing for you:
https://github.com/WW-Digital/reactive-kinesis/blob/master/src/main/scala/com/weightwatchers/reactive/kinesis/consumer/KinesisConsumer.scala#L251

Seems like the consumer is shutting down before that. Happy to merge this but would you mind adding this to the readme too please with an example?
https://github.com/WW-Digital/reactive-kinesis#akka-stream-source

@htimur
Copy link
Contributor Author

htimur commented Apr 20, 2018

@markglh Ok will update the docs and then the PR.

@coveralls
Copy link

coveralls commented Apr 23, 2018

Coverage Status

Coverage decreased (-0.6%) to 89.522% when pulling 462539a on htimur:master into c635b6f on WW-Digital:master.

@htimur
Copy link
Contributor Author

htimur commented Apr 23, 2018

@markglh Please review the changes

Copy link
Contributor

@markglh markglh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants