This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Update dependencies #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, I guess I'll have to take a closer look at the integration tests… |
|
Okay, without the upgrade of |
|
@markglh would you take a look? |
agaro1121
reviewed
Jan 29, 2019
| @@ -216,6 +216,15 @@ class ConsumerConfSpec | |||
| | # Default: not set | |||
| | logWarningForTaskAfterMillis = 100 | |||
| | | |||
| | # The sleep time between two listShards calls from the proxy when throttled. | |||
| | # Default: 1500 | |||
| | listShardsBackoffTimeInMillis = 1500 | |||
There was a problem hiding this comment.
We should probably add these to the reference.conf in main for visibility
|
Hey @JannikArndt - apologies for the delay, I didn't get notified about the PR. The KCL upgrade includes the new 2.x Core DK which conflicts with the KPL. So we need to split it into modules to get around that. The KPL team are really slow to update. Would you mind addressing @agaro1121's comment then I'll merge this in? |
|
Got a request to merge this from @etspaceman - so I'll do that and we can push the fix in a new PR |
markglh
approved these changes
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
sbt1.1.1 -> 1.2.8scala2.12.5 -> 2.12.8jackson2.9.4 -> 2.9.8akka2.5.11 -> 2.5.19amazon-kinesis-client1.8.10 -> 1.9.3amazon-kinesis-producer0.12.8 -> 0.12.11scala-logging3.8.0 -> 3.9.0Note: KCL has two new fields:
listShardsBackoffTimeInMillismaxListShardsRetryAttempts