-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #60
base: master
Are you sure you want to change the base?
Conversation
Add Laravel 8 dependencies
@sildraug @zarianec @adrianhurt @dgoguerra Please merge this! |
While @sildraug is reviewing the code (and assuming the patch is accepted), you can use the power of composer:
"repositories": [
{
"type": "vcs",
"url": "https://github.com/cyrillkalita/Sanitizer"
}
],
"require": {
...
"waavi/sanitizer": "dev-laravel-8-patch",
...
} This will instruct composer to replace the canonical Not ideal, I understand, but everyone's got a life and we have to respect authors, maintainers, and their time. |
You can also use this:
|
@abderrazzak-oxa not sure which of "not-ideal" solutions is less not ideal; locking the framework dependency or pointing to the patch. For anyone looking for a quick solution, please remember, this should not be your production solution. On one hand, the framework has been known to release security patches and locking to a version will prevent you from getting those. Upside - it keeps you On another hand, replacing package with a patched version opens you to all sorts of malice from an unknown source, who can continue to add code. An obvious reason to not use it in production. It would really be helpful through is @sildraug will decide if he wants to merge this code, though. |
@sildraug do you think you can review this PR? |
For anyone still interested, I forked the repo into a stable version 8 here: Moving forward supports only Laravel 8 over PHP7.3 |
Thank you @cyrillkalita |
Add Laravel 8 dependencies, as per #59