Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few cleanups #45

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

A few cleanups #45

wants to merge 5 commits into from

Conversation

neuschaefer
Copy link

Hi,

while trying to build maciNTosh in GitHub Actions CI, I ended up fixing a few things. Please take what you like :)

@Wack0
Copy link
Owner

Wack0 commented Nov 4, 2024

I'm not sure if I want to have github ci present in this repo.

That said, the other commits look good, can you squash them?

@neuschaefer
Copy link
Author

neuschaefer commented Nov 4, 2024

I'm not sure if I want to have github ci present in this repo.

That said, the other commits look good, can you squash them?

I always find squashing to be a rather lossy deal because it breaks the connection between specific commit message and content, so I prefer not to. I'll remove the CI commit though, and see what I can squash without significant loss of information.

I'm also a bit unsure about the last two (Work around(?) LD error: PHDR segment not covered by LOAD segment and Ignore incompatible-type errors). They point to real problems with newer toolchains, but the solutions might be problematic.

EDIT: feel free to merge now

@neuschaefer neuschaefer changed the title GitHub CI and a few cleanups A few cleanups Nov 19, 2024
@neuschaefer
Copy link
Author

rebased, and removed questionable commits (-Wno-...) for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants