Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Boot v3.0 support #1813

Closed
nclemeur opened this issue Jan 9, 2023 · 15 comments
Closed

Spring Boot v3.0 support #1813

nclemeur opened this issue Jan 9, 2023 · 15 comments
Assignees
@hazendaz

Comments

@nclemeur
Copy link

nclemeur commented Jan 9, 2023

Hello,
I would like to know if it is already possible to use waffle integration with sprint boot 3.0? I notice there is already a package waffle-jna-jakarta, but there is no waffle-spring-boot3 and/or waffle-spring-security6?
@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023 via email

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023 via email

@ekkelenkamp
Copy link

Is there any chance that waffle-spring-security6 will also be supported for waffle 2.3.0?

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023 via email

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023

To add to why not 2.3.0, its not supported here, it does not work with jdk 14+ either at least as it pertains to JAAS changes which are not related to spring / spring boot but do prevent repo from building. There should not be anything otherwise preventing update to 3.2.0 or future released versions as they mostly dropped legacy support or further secured application. The jump was MIT license change and ability to change out cache.

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023

Code for spring / spring boot 3 is now going to be available here per #1814 but no plan to release that with overall library and have not built out any demo code for the same. I'll look to build out demo code in some other pull request but ultimately before release will start breaking up the repo as I had noted here. The main thing is to understand this repo keeps growing in size and the release already takes far too long (hours) whereas breaking it up will make it take minutes instead. The major issue with releases is the site itself for maven as it doesn't function well with multi modules keep growing.

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023

also note, the code I'm adding is yet to actually be tested. There are likely some other changes necessary and I don't expect that I'll be testing this in sort order so if you want to build from master after this is applied, you will have to use jdk 17 to do so and if you find any issues you can resolve, please submit another PR to patch. It will likely be at least a week before I get to trying to test this and build out the demos. And probably a month or so before I can formally break things up.

@hazendaz
Copy link
Member

hazendaz commented Jan 9, 2023

Master now has spring security 6 / spring boot 3 support in place. Will leave this open as work to get released along with breakups not completed but feel free to build now and test.

@hazendaz
Copy link
Member

I went ahead and added demo here, I still want to break up but have made it so its possible to add most things here. I may leave as such to get support out but still haven't done any formal testing on this.

@hazendaz
Copy link
Member

due to lack of time, I plan to keep this together and release all. However, I've yet to get the demo working. Its giving back indication of successful logon but then throws invalid token error. I'm at a loss at the moment for what the issue is. I did explore trying to disable explicit save on context but that didn't change behaviour. I think I have everything else addressed for migration so any help there would be appreciated. Just run full build then go to the spring boot 3 demo and launch that via spring boot to test. It will prompt for logon, use 'admin' for that with no password to see the issue. Also documented in readme.

@ivanfomkin
Copy link

ivanfomkin commented Feb 27, 2023 •
edited
Loading

due to lack of time, I plan to keep this together and release all. However, I've yet to get the demo working. Its giving back indication of successful logon but then throws invalid token error. I'm at a loss at the moment for what the issue is. I did explore trying to disable explicit save on context but that didn't change behaviour. I think I have everything else addressed for migration so any help there would be appreciated. Just run full build then go to the spring boot 3 demo and launch that via spring boot to test. It will prompt for logon, use 'admin' for that with no password to see the issue. Also documented in readme.

I try to run demo and i get exception
But when i build waffle project and use waffle-spring-boot-starter3 dependency in my project - it works fine: I can get Kerberos user in my controller

@hazendaz
Copy link
Member

I can get a release together with known defect on the demo and state its a release candidate. Will try for this coming weekend.

@fJavierParada
Copy link

Hi,
any progress or news on this issue?
Thanks in advance!

@hazendaz
Copy link
Member

going to try this weekend. after spring boot releases a patch.

@hazendaz
Copy link
Member

This has been released, I opened a new ticket in regards to broken demo for spring boot 3 in case anyone wants to try to fix that. See #1913 linking these.

@hazendaz hazendaz self-assigned this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hazendaz hazendaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hazendaz @ekkelenkamp @nclemeur @ivanfomkin @fJavierParada