Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation refers to 1.8.1 but there is no 1.8.1 release on GitHub #375

Closed
alshain opened this issue Jul 14, 2016 · 10 comments
Closed

Documentation refers to 1.8.1 but there is no 1.8.1 release on GitHub #375

alshain opened this issue Jul 14, 2016 · 10 comments

Comments

@alshain
Copy link
Contributor

alshain commented Jul 14, 2016

The 1.8.1 release only seems to be on maven. Releases and the readme only show 1.8.0

However, the documentation everywhere on GitHub refers to 1.8.1 JARs, which are not easily available for download.

@hazendaz
Copy link
Member

All java pieces for 1.8.1 are on maven central. The bundle on releases while missing would only additionally have .net code which i think didnt change over 1.8.0. However thanks for pointing it out. Ill get a bundle up there as soon as i can. Ill probably retool releases so its additionally clear where our manual bundles are vs maven tags and ill link that to readme.

Good catch thanks.

Get Outlook for Androidhttps://aka.ms/ghei36

On Thu, Jul 14, 2016 at 6:20 AM -0400, "Chris" <notifications@github.commailto:notifications@github.com> wrote:

The 1.8.1 release only seems to be on maven. Releaseshttps://github.com/dblock/waffle/releases and the readmehttps://github.com/dblock/waffle/blob/master/README.md only show 1.8.0

However, the documentation everywhere on GitHub refers to 1.8.1 JARs, which are not easily available for download.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/375, or mute the threadhttps://github.com/notifications/unsubscribe/AA7ho-qO5NJ6co0TkkkZs0OXhow0PNQTks5qVg1rgaJpZM4JMSVt.

@sindilevich
Copy link

@hazendaz, there was some changes to the .NET part as well in 1.8.1, something with correct handling of possible return/error codes.

I'll be also glad if you could release 1.8.1 including the .NET binaries.

@devnullpointer
Copy link
Contributor

I see 1.8.1 on the Releases section. Just click the "Show newer tags", its there as of Feb 10..

@sindilevich
Copy link

@devnullpointer, thank you for your reply. I did find the hidden tags, but when you download the ZIP file at the 1.8.1 tag, it only contains the source code, without compiled DLL's. The 1.8.0's download, however, contains the compiled DLL's.

@hazendaz
Copy link
Member

.net portion doesnt change too often but we will have to fix that so its consistent. We are what i would consider good for next release but...tomcat 8.5 and 9.0 changed signatures so we need to figure out how we might want to support old and new before we push the next release.

Get Outlook for Androidhttps://aka.ms/ghei36

On Mon, Oct 17, 2016 at 2:12 PM -0400, "Matanel Sindilevich" <notifications@github.commailto:notifications@github.com> wrote:

@devnullpointerhttps://github.com/devnullpointer, thank you for your reply. I did find the hidden tags, but when you download the ZIP file at the 1.8.1 tag, it only contains the source code, without compiled DLL's. The 1.8.0's download, however, contains the compiled DLL's.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/375#issuecomment-254287528, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA7ho087UnDyI_6V8wlCW9PSDU7GQrCRks5q07qFgaJpZM4JMSVt.

@sindilevich
Copy link

@hazendaz, thank you for your reply!

Version 1.8.1 had a bug fixed with .NET portion too (#128), so I thought it is worth compiling the DLL's for.

@hazendaz
Copy link
Member

@sindilevich I got the tomcat8.5 / tomcat9 pieces working so getting closer to a release which will include everything. I'm having some issues with waffle-tests working at the moment on java side which will take a bit of research. As soon as I get that all resolved, I plan to get a release out so wanted to give you a heads up of where we stand at the moment.

@sindilevich
Copy link

@hazendaz, thank you! Waiting forward for the new release.

@hazendaz
Copy link
Member

@sindilevich I expect to have the release in next week or so. I've resolved all the issues I had outstanding. There was one issue opened today so waiting on user feedback there to make the release.

@hazendaz
Copy link
Member

Closing issue as 1.8.2 will be released and I have a task for that. Since we are only wanting a specific fix out of .net code not going to bother with getting a 1.8.1 copy released. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants