Support authorization in service provider #174
Conversation
Add possibility for service provider to add authorization by overriding setAuthentication
A NegotiateSecurityFilter that supports dependency injection to authorize principal at serviceprovider after authenticating in AD.
|
Thanks! Can you explain a bit better what this does? Other than that it all looks fine, it needs an update to CHANGELOG, some documentation update(s) and I would love a test for this, too, if that's not too hard. Please squash your commits, too. |
|
An example project that we can run would be great as well helping people use this. See demos of waffle for how to provide an example. Also spring 4 version we be good too. No need to worry about spring 2 as its days are numbered. --- Original Message --- From: "Daniel Doubrovkine (dB.) @dblockdotorg" notifications@github.com This all looks fine, it needs an update to CHANGELOG, some documentation update(s) and I would love a test for this, too, if that's not too hard. Reply to this email directly or view it on GitHub: |
|
Hi - I don't have access to spring 4 within the project so that will be hard. I'll see if I'm competent enough to write a proper testcase. I'll update the CHANGELOG. Where do I put the documentation updates? |
|
Changeling is on root of master. Any other docs are under docs on root. Spring 4 is at the moment identical to spring 3 so blindly adding as long as it builds is good enough. Look at overall setup of development as spring security 4 needs installed to your local repo. There is a batch file under third party to do that. Let me know if you need anything else. --- Original Message --- From: "Christopher Suarez" notifications@github.com Hi - I don't have access to spring 4 within the project so that will be hard. I'll see if I'm competent enough to write a proper testcase. I'll update the CHANGELOG. Where do I put the documentation updates? Reply to this email directly or view it on GitHub: |
Support authorization in service provider
|
Oh - you squashed it aswell? Sorry, I was going to do that for you when I was done :-) |
|
Cool, you guys are awesome. |
|
No problem. This looked safe and I was doing some other work so took it. If you got a little more coming just open a new pull request and I'll take it. When you are ready for an official release let me know and I'll get that out there as well. I thought something might be left in the works but since this doesn't necessarily change any current usage it was good to go. --- Original Message --- From: "Christopher Suarez" notifications@github.com Cool, you guys are awesome. Reply to this email directly or view it on GitHub: |
|
No @csms, you are awesome :) |
Hi. Please review and merge if you like and have time.
I appologize for any mistakes.