Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added continueContextsTimeout property to WaffleAuthenticatorBase for tomcat 6,7,8. #196

Closed
wants to merge 2 commits into from

Conversation

alanlavintman
Copy link

I have added support for external configuration of the continueContextTimeout property required by the WindowsAuthProvider. All WaffleAuthenticatorBase classes now override the start method in order to create an instance of the WindowsAuthProviderImpl.
I have checked all inherited classes to call their base and all unit tests passes.

@hazendaz
Copy link
Member

hazendaz commented Feb 1, 2015

Can you update the changelog for waffle found in the root folder as well as write some unit tests? Additionally can you look at enhancing the examples to use this new functionality?

@alanlavintman
Copy link
Author

Sure, updating this tonight :)

@hazendaz
Copy link
Member

@alanlavintman If you want this pull request aplied, please update the changelog and write some unit tests. We will take this as soon as that is completed. Thanks.

@hazendaz
Copy link
Member

@alanlavintman Do you still want to get this pulled into waffle? It's been about a year so I need to make a determination if this should come in or not. If you do still want this, please make the same changes against the tomcat 9 version that is now present.

If I don't hear anything back I might still pull this in on my own but not sure on timetable there. I'll want to thoroughly review it first and go from there. I'm pretty busy otherwise with other things so if you can help, or really anyone else that reads these, that would be very welcomed.

@hazendaz
Copy link
Member

@alanlavintman Do you still want this change? I'm getting ready to push a release so if you do, please rebase this and add the support to tomcat 8.5 and 9.0 as well.

@hazendaz
Copy link
Member

Merged per #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants