[issue #203] Catch Win32Exception and make 401 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix to capture tomcat 6, 7, and 8 negotiate authenticator Win32Exception which started occurring around June 2015 per issue #107. Around that time Exception was switched out for IOException which allowed Win32Exception to occur. Now catch that and perform same actions as IOException. Left original unit tests capturing fall through and added new check as this shows Negotiate, NTLM where the comma was normally expected to be a space. This does fix the condition but I'm not 100% certain this is correct from unit test side.
|
This is good. CHANGELOG? Feel free to merge after. |
|
It would be nice if the UT could be more predictable, like for example that the 401 is actually produced. But it's ok if it's not easy to do. |
hazendaz
added a commit
that referenced
this pull request
Apr 11, 2015
[issue #203] Catch Win32Exception and make 401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to capture tomcat 6, 7, and 8 negotiate authenticator
Win32Exception which started occurring around June 2015 per issue #107.
Around that time Exception was switched out for IOException which
allowed Win32Exception to occur. Now catch that and perform same
actions as IOException. Left original unit tests capturing fall through
and added new check as this shows Negotiate, NTLM where the comma was
normally expected to be a space. This does fix the condition but I'm
not 100% certain this is correct from unit test side.