Introduce Tomcat 8.5.x and Similar Changes for Tomcat 9.0.0.m4 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native compilation needed jaspic-api which isn't available in central at this point so using it in-line differently than we have in the past since it's provided scope 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using maven system scope for jaspic-api.jar at this point in time as tomcat has not released it to central nor has any other source. Tomcat 8.5.x is still considered beta. Tomcat 8.5.0 and 9.0.0.m4 are equivelant except that tomcat 8.5.0 will continue on servlet 3.1.0 and allow java 7. The major reason at this point in time for inclusion of these is the jaspic code as it's a compilation requirement at this point. As with before, tomcat 9 that was introduced earlier will not be compiled during our auto build process as it required java 8. The travis job will pick it up on java 8 run though and run an attempt on it but that will not report back issues to us. Case in point, 9.0.0.m4 wouldn't build until I added jaspic-api as a dependency.