-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default setter for authentication #382
Conversation
@unaor Should spring 3 module have this same change? If so, can you add that and push it up as well? |
This definitely needs tests and a CHANGELOG entry, please. |
We're missing a test for this Delegating* thing in https://github.com/dblock/waffle/tree/master/Source/JNA/waffle-spring-security3/src/test/java/waffle/spring, please add one. |
@dblock I added a basic test that checks that the custom handler is setted correctly and another test to make sure that Authentication is not null (that was original bug). |
That looks better, I will leave it to @hazendaz from here. |
@unaor Can we get the tests in spring3 too? Looks like you added it for only spring4. I'll merge right after. Also wondered if you were still planning on providing documentation for how you got this up and running in spring boot as well. I find that very useful info. |
I'll get the tests in spring 3 shortly. |
In case that user wants to just add handlers but not to provide a custom authentication ,the auth object is not saved
this will fix it