Full Mavenization Part 2 - some minor cleanup #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligning to standard maven layout.
Removed method that is not override and therefore doesn't exist in tomcat 5 version in use.
moved files into maven standard layout.
move tomcat 6 files into standard maven layout
still having issues with
dropped empty context.xml as not needed. moved logback.xml into correct location.
added default statements to case statements - just using break there. So nothing special.
hazendaz
added a commit
that referenced
this pull request
Apr 9, 2014
Full Mavenization Part 2 - some minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using standard maven layout.
Some sonar related cleanup such as case statements should have default. Just using break in the default to comply.
Fixed one test cases where my machine name was getting all caps but the resulting value to compare against was mixed case. Since it was valid, made it lowercase the names to make the tests work for my instance. This would have affected others depending on how the environment is setup.