Updated documentation & fixed some issues #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First cut to update documentation to reflect maven builds. Note: All documentation needs reviewed as some notes about builds appears to have changed some time ago and was unsure how to address. This only addresses general maven build & already present was the deployment to maven central. It does not go into maven site generation or other profiles yet.
Added additional information to poms so users can easily determine what version of the jdk is expected to be used. This is more important since tomcat8 requires java7.
Updated all web.xml files to use universal character encoding rather than legacy ISO-8859-1.
Corrected issues in waffle filter pom preventing it from working properly. Eclipse had issues importing in the form it was. Also removed information regarding the prior non maven layout. Final war build will no longer contain version number so it is easier to drop and deploy for users testing.
hazendaz
added a commit
that referenced
this pull request
Apr 24, 2014
Updated documentation & fixed some issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated majority of documentation to show maven setup beyond what was done earlier by Ryan.
Fixed some issues discovered when attempting to import the filter demo.
Added more manifest information which now includes it on all generated jars/wars along with jdk version it is targeting for source and compilation. This is helpful to the users especially for tomcat8 since it requires jdk7.