Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wafris logs connection error even when it is not enabled #5

Closed
jmadlena opened this issue Jan 10, 2024 · 8 comments · Fixed by #6
Closed

[Bug]: Wafris logs connection error even when it is not enabled #5

jmadlena opened this issue Jan 10, 2024 · 8 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@jmadlena
Copy link
Contributor

What happened?

For local development I have Wafris disabled. But I see a Wafris connection error in my logs for every request, which can clutter it up and make it hard to read.

Wafris error: Connection refused [tcp://127.0.0.1:6379]

How to reproduce the bug

  1. Install Wafris per the readme in a Laravel 10 application
  2. Disable Wafris (wafris.enabled = false)
  3. Make a request

Package Version

0.0.2

PHP Version

8.2.14

Laravel Version

10.40

Which operating systems does with happen with?

macOS

Notes

No response

@jmadlena jmadlena added the bug Something isn't working label Jan 10, 2024
@rmcastil
Copy link
Contributor

@jmadlena thanks for this feedback. I'll start working on a patch to suppress these messages.

@jmadlena
Copy link
Contributor Author

@rmcastil Thanks! Let me know if I can do anything to help.

@rmcastil
Copy link
Contributor

rmcastil commented Jan 11, 2024 via email

@jmadlena
Copy link
Contributor Author

I could certainly take a crack at it. I'll make a PR for you review soon.

@MiniCodeMonkey
Copy link
Collaborator

I went ahead and PR'ed a fix for this 🙌

@rmcastil
Copy link
Contributor

rmcastil commented Feb 7, 2024 via email

@jmadlena
Copy link
Contributor Author

jmadlena commented Feb 8, 2024

@rmcastil Since this was merged, will a new release be tagged so it can updated via composer like normal?

@rmcastil
Copy link
Contributor

rmcastil commented Feb 8, 2024

@jmadlena yup! Will try and get to that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants