-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Wafris logs connection error even when it is not enabled #5
Comments
@jmadlena thanks for this feedback. I'll start working on a patch to suppress these messages. |
@rmcastil Thanks! Let me know if I can do anything to help. |
If you want it sooner than later you could submit a PR. We don’t have an
official Laravel maintainer so I’m usually having to carve out extra
time to make sure I’m doing the Laravel stuff right.
We would of course add you to the contributor list.
On January 11, 2024, GitHub ***@***.***> wrote:
@rmcastil <https://github.com/rmcastil> Thanks! Let me know if I can
do anything to help.
—
Reply to this email directly, view it on GitHub
<#5 (comment)-
1888073825>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AABF6M6OEO3BGI3VRA3TY2LYOBR63AVCNFSM6AAAAABBVFJPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGA3TGOBSGU>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I could certainly take a crack at it. I'll make a PR for you review soon. |
I went ahead and PR'ed a fix for this 🙌 |
Thanks Mathias! Merged.
…On February 5, 2024, GitHub ***@***.***> wrote:
I went ahead and PR'ed a fix for this 🙌
—
Reply to this email directly, view it on GitHub
<#5 (comment)-
1926540772>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AABF6MYLIIDRSKUYJTGAFO3YSCQBZAVCNFSM6AAAAABBVFJPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWGU2DANZXGI>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@rmcastil Since this was merged, will a new release be tagged so it can updated via composer like normal? |
@jmadlena yup! Will try and get to that today. |
What happened?
For local development I have Wafris disabled. But I see a Wafris connection error in my logs for every request, which can clutter it up and make it hard to read.
How to reproduce the bug
Package Version
0.0.2
PHP Version
8.2.14
Laravel Version
10.40
Which operating systems does with happen with?
macOS
Notes
No response
The text was updated successfully, but these errors were encountered: