Adding Other Shelves #98
Conversation
|
Examples of other shelf assemblies that are being added. There is an automatically captured image of the assembly, followed by an image of the exploded assembly, for each shelf. |
|
Awesome, we are really cooking on gas now. I'm going to try to get this all synced up so the renders are generated from the CadOrchestrator commands and server |
julianstirling
force-pushed
the
other-shelves
branch
from
77980e3 to
10dabb8
Compare
There was a problem hiding this comment.
Hi @jmwright
Great work here I have checked over the code and made a couple of comments and a minor suggestion.
I realise however than on rebasing I have slightly buggered up the renders, probably to do with the fastener axis:
Is it OK if I leave this to you to fix? I am going to click approve on this so you can merge once you fix my mistake
| explode_translation=explode_translation, | ||
| size=size, | ||
| fastener_type=fastener_type, | ||
| direction_axis=axis) |
There was a problem hiding this comment.
Is there a reason that the parameter is axis in Ziptie but directional_axis in the parent class Fastener?
There was a problem hiding this comment.
I think I was trying to keep the variables separate as they're passed through the constructor and super calls on Screw and Ziptie.
Co-authored-by: Julian Stirling <julian@julianstirling.co.uk>
|
@julianstirling I don't think you messed the alignment up. Please make sure that cq-annotate is up-to-date in your environment with the latest in the main branch on git. |
There are shelf assemblies outlined in the database and in the code that are not accounted for yet. This PR is an attempt to add some of those. #94 needs to be merged first, and potentially the new CadOrchestrator changes need to be merged and then used to reshape this PR.