Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow ssh #72

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature/allow ssh #72

wants to merge 6 commits into from

Conversation

Philippe117
Copy link
Member

Ajoute l'utilisation du ssh.

pour tester

FORCE_SSH=true
INSTALL_SARA
UPDATE_SARA
STATUS_SARA
SCRAPE_SARA_CONFIG

@Philippe117 Philippe117 marked this pull request as ready for review May 27, 2020 02:00
@Philippe117 Philippe117 self-assigned this May 27, 2020
Copy link
Member

@duchainer duchainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set $FORCE_SSH under https comments to false
Also make sure that the sed calls are valid git paths


######################################
## Set back to https if needed
if [[ $FORCE_SSH == "true" ]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si on a set à ssh, je remet à https pour éviter les conflits avec git

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comme ça, le .rosinstal utilise toujours https mais est changé au besoin. Un peut comme du JIT/JAT

@@ -73,6 +82,14 @@ fi
#rm /tmp/sara_install_ws


######################################
## Set back to https if needed
if [[ $FORCE_SSH == "true" ]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every https seems to have the wrong $FORCE_SSH value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voir ma réponse au dessu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants