Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PCM_S24LE. #89

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Add support for PCM_S24LE. #89

merged 2 commits into from
Apr 28, 2023

Conversation

devoxin
Copy link
Contributor

@devoxin devoxin commented Mar 15, 2023

No description provided.

@Walkyst
Copy link
Owner

Walkyst commented Apr 15, 2023

Thanks for PR! Can you send example of audio that is require this change?

@devoxin
Copy link
Contributor Author

devoxin commented Apr 16, 2023

Certainly! An example S24LE audio file can be found here.

You can generate your own S24LE audio files with the following ffmpeg command:
ffmpeg -i <input file> -f s24le output_file.wav

@Walkyst Walkyst merged commit 9c9ca0d into Walkyst:original Apr 28, 2023
@Walkyst
Copy link
Owner

Walkyst commented Apr 28, 2023

Please make other PR if you want this on custom branch too

This was referenced Apr 28, 2023
Merged
Merged
@devoxin devoxin deleted the walkyst-original branch April 14, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoxin @Walkyst