Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W3m integration update #1373

Merged
merged 12 commits into from
Jun 19, 2024
Merged

W3m integration update #1373

merged 12 commits into from
Jun 19, 2024

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Jun 14, 2024 •
edited
Loading

Description

  • integrates 1ca web3modal
  • fixes error code mappings
  • fix issue with failing to open link mode url

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jackpooleywc
jackpooleywc approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@jackpooleywc jackpooleywc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@llbartekll llbartekll merged commit 6f98b57 into develop Jun 19, 2024
6 checks passed
@llbartekll llbartekll deleted the w3m-integration-update branch June 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpooleywc jackpooleywc jackpooleywc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llbartekll @jackpooleywc