Verify v2 #1392
Merged
Verify v2 #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public struct P256JWTValidator { | ||
|
|
||
| let jwtString: String |
There was a problem hiding this comment.
Can this be private?
Suggested change
| let jwtString: String | |
| private let jwtString: String |
| self.jwtString = jwtString | ||
| } | ||
|
|
||
| public func isValid(publicKey: P256.Signing.PublicKey) throws -> Bool { |
There was a problem hiding this comment.
not as a unit here but we have it covered in the AttestationJWTVerifierTests as it depends on P256JWTValidator
Comment on lines
125
to
127
| func getVerifyContext(requestId: RPCID, domain: String) -> VerifyContext { | ||
| (try? verifyContextStore.get(key: requestId.string)) ?? verifyClient.createVerifyContext(origin: nil, domain: domain, isScam: false) | ||
| } |
There was a problem hiding this comment.
I find this a bit easier to read.
Suggested change
| func getVerifyContext(requestId: RPCID, domain: String) -> VerifyContext { | |
| (try? verifyContextStore.get(key: requestId.string)) ?? verifyClient.createVerifyContext(origin: nil, domain: domain, isScam: false) | |
| } | |
| func getVerifyContext(requestId: RPCID, domain: String) -> VerifyContext { | |
| guard let context = try? verifyContextStore.get(key: requestId.string) else { | |
| return verifyClient.createVerifyContext(origin: nil, domain: domain, isScam: false) | |
| } | |
| return context | |
| } |
| @@ -56,7 +56,14 @@ class AuthRequestSubscriber { | |||
| Task(priority: .high) { | |||
| let assertionId = payload.decryptedPayload.sha256().toHexString() | |||
| do { | |||
| let response = try await verifyClient.verifyOrigin(assertionId: assertionId) | |||
| let response: VerifyResponse | |||
There was a problem hiding this comment.
see warning: let assertionId = payload.decryptedPayload.sha256().toHexString() 👆
| @@ -397,7 +401,14 @@ private extension ApproveEngine { | |||
| Task(priority: .high) { | |||
| let assertionId = payload.decryptedPayload.sha256().toHexString() | |||
| do { | |||
| let response = try await verifyClient.verifyOrigin(assertionId: assertionId) | |||
| let response: VerifyResponse | |||
|
|
||
| func fetchPublicKey() async throws -> VerifyServerPublicKey { | ||
| guard let url = URL(string: urlString) else { | ||
| throw NSError(domain: "", code: 0, userInfo: [NSLocalizedDescriptionKey: "Invalid URL"]) |
There was a problem hiding this comment.
just out of curiosity is there a reason we use an NSError here? What not use a custom type conforming to Error?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements verify v2 api
Resolves # (issue)
How Has This Been Tested?
Due Dilligence