[Push] Sync subscriptions #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
reviewed
Jun 18, 2023
Sources/WalletConnectPush/Client/Common/DeletePushSubscriptionSubscriber.swift
Outdated
Show resolved
Hide resolved
llbartekll
reviewed
Jun 18, 2023
...onnectPush/Client/Wallet/ProtocolEngine/wc_notifyUpdate/NotifyUpdateResponseSubscriber.swift
Outdated
Show resolved
Hide resolved
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
63c113d
to
d8b9365
Compare
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
3358b98
to
c8be622
Compare
yes, we're discussing keys sync here: https://github.com/WalletConnect/walletconnect-docs/pull/773/files |
flypaper0
commented
Jun 22, 2023
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
5c69171
to
744af6f
Compare
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
910ce67
to
b972182
Compare
llbartekll
approved these changes
Jun 27, 2023
...nectPush/Client/Wallet/ProtocolEngine/wc_pushSubscribe/PushSubscribeResponseSubscriber.swift
Show resolved
Hide resolved
...nectPush/Client/Wallet/ProtocolEngine/wc_pushSubscribe/PushSubscribeResponseSubscriber.swift
Outdated
Show resolved
Hide resolved
...nectPush/Client/Wallet/ProtocolEngine/wc_pushSubscribe/PushSubscribeResponseSubscriber.swift
Outdated
Show resolved
Hide resolved
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
1f02c87
to
86c4218
Compare
flypaper0
force-pushed
the
feature/sync-subscriptions
branch
from
7989dc1
to
75bc40d
Compare
llbartekll
reviewed
Jun 29, 2023
| @@ -21,10 +23,19 @@ final class PushTests: XCTestCase { | |||
|
|
|||
| var pairingStorage: PairingStorage! | |||
|
|
|||
| let pk = try! EthereumPrivateKey() | |||
There was a problem hiding this comment.
sometimes we re running those tests against prod cast and prod gm dapp. Can we use some fixed entropy here for deriving the private key? to not pollute their DBs
There was a problem hiding this comment.
Why we can pollute db's? I think there will be same amount of relay messages in both cases (random and derived private key)
llbartekll
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence