Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use new logger canary #4426

Merged
merged 5 commits into from
Apr 9, 2024
Merged

chore: use new logger canary #4426

merged 5 commits into from
Apr 9, 2024

Conversation

devceline
Copy link
Contributor

@devceline devceline commented Apr 8, 2024 •
edited
Loading

Description

Note

Uses Changes from: WalletConnect/walletconnect-utils#167

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Tested via the repro case mentioned in issue #4414

Fixes/Resolves (Optional)

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@devceline devceline requested a review from ganchoradkov April 8, 2024 19:08
@devceline devceline marked this pull request as ready for review April 8, 2024 19:08
@devceline devceline requested a review from bkrem April 8, 2024 19:18
@devceline devceline merged commit 2d945ca into v2.0 Apr 9, 2024
9 checks passed
@devceline devceline deleted the fix/logger-build-error branch April 9, 2024 10:32
@ganchoradkov ganchoradkov mentioned this pull request Apr 9, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

@bkrem bkrem Awaiting requested review from bkrem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Writable" is not exported by "__vite-browser-external"
2 participants
@devceline @ganchoradkov