Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init event #5343

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: init event #5343

merged 5 commits into from
Sep 16, 2024

Conversation

ganchoradkov
Copy link
Member

Description

context: https://www.notion.so/walletconnect/Walletkit-events-sdk-init-event-08b51439dd8b42c5bbe993c63d2ce54e

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Sep 9, 2024
@ganchoradkov ganchoradkov requested review from Cali93 and bkrem September 9, 2024 11:34
bkrem
bkrem approved these changes Sep 16, 2024
View reviewed changes
packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
Cali93
Cali93 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that we address the bundleId comment. Did you align on the format with the data team?

packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
packages/core/src/controllers/events.ts
timestamp: Date.now(),
props: {
event: "INIT",
type: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dnul if you're relying on the type here, what should the value be ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the specs https://www.notion.so/walletconnect/Walletkit-events-sdk-init-event-08b51439dd8b42c5bbe993c63d2ce54e?pvs=4#49045ac3ba8d4f36900a24047b9cc87b

val event: String = "INIT"
val type: String, // None

packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit ed0fae5 into v2.0 Sep 16, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the feat/init-event branch September 16, 2024 14:35
@ganchoradkov ganchoradkov mentioned this pull request Sep 18, 2024
Merged
20 tasks
github-merge-queue bot referenced this pull request in valora-inc/wallet Sep 21, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
993f86b 
…^2.16.2 (#6064)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://redirect.github.com/walletconnect/walletconnect-monorepo)
| [`^2.16.1` ->
`^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2)

[Compare
Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2)

#### What's Changed

- feat: init event by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343)
- feat: fetch call status via bundler url by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171)
- fix: sets domain if available else sets `sp` by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.16.1...2.16.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Sep 22, 2024
@renovate @satish-ravi
chore(deps): update dependency @walletconnect/utils to ^2.16.2 (#6065)
83c8319 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/utils](https://redirect.github.com/walletconnect/walletconnect-monorepo)
| [`^2.16.1` ->
`^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.16.1/2.16.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/utils)</summary>

###
[`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2)

[Compare
Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2)

##### What's Changed

- feat: init event by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343)
- feat: fetch call status via bundler url by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171)
- fix: sets domain if available else sets `sp` by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.16.1...2.16.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali93 Cali93 Cali93 approved these changes

@bkrem bkrem bkrem approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganchoradkov @bkrem @Cali93 @arein