minor edits #106
Open
minor edits #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahiheb
suggested changes
Oct 14, 2022
| @@ -51,6 +51,151 @@ satisfied or after a timeout. | |||
| 5. **Transaction Broadcast** - The coordinator broadcasts the transaction and waits | |||
| for confirmation in a block. | |||
|
|
|||
| Timeouts are considered a failure except during input registration, where the | |||
There was a problem hiding this comment.
All of this section must have been added by mistake. It should be removed.
BTCparadigm
reviewed
Oct 15, 2022
Comment on lines
53
to
+60
|
|
||
| Timeouts are considered a failure except during input registration, where the | ||
| round may still proceed if a sufficient number of participants have joined. | ||
| Failure during any phase will cause the round as a whole to fail, apart from | ||
| output registration which unconditionally proceeds to the signing phase in | ||
| order to assign blame. Signed inputs reveal that a user executed the protocol | ||
| honestly, allowing faulty/malicious users to be excluded from a re-attempted | ||
| round. |
There was a problem hiding this comment.
You mean this?
Suggested change
| Timeouts are considered a failure except during input registration, where the | |
| round may still proceed if a sufficient number of participants have joined. | |
| Failure during any phase will cause the round as a whole to fail, apart from | |
| output registration which unconditionally proceeds to the signing phase in | |
| order to assign blame. Signed inputs reveal that a user executed the protocol | |
| honestly, allowing faulty/malicious users to be excluded from a re-attempted | |
| round. |
BTCparadigm
reviewed
Oct 15, 2022
BTCparadigm
reviewed
Oct 15, 2022
BTCparadigm
reviewed
Oct 15, 2022
BTCparadigm
reviewed
Oct 15, 2022
| account for traffic analysis-based attacks, and that the structure of the | ||
| CoinJoin transaction provide sufficient privacy against passive observers. | ||
|
|
||
| This leaves Sybil attacks by other users or the coordinator, and attacks by the coordinator such as targeted denial of service by the coordinator for the purpose of deanonymization (e.g., facilitating an intersection attack on specific input or output registrations) or timing analysis. Sybil attacks by users or the coordinator have a liquidity requirement cost requirements depending on Bitcoin network fees. |
BTCparadigm
reviewed
Oct 15, 2022
|
|
||
| #### `EncryptedUnsignedCoinJoin` | ||
|
|
||
| When a participant registers an output, the coordinator gives an `UnsignedTransactionSecret` as response. With this, during the signing phase, the participant can decrypt the `EncryptedUnsignedCoinJoin` to sign it. This ensures only the participants of a round learn the CoinJoin before it is broadcast. This feature is not strictly necessary. |
There was a problem hiding this comment.
Suggested change
| When a participant registers an output, the coordinator gives an `UnsignedTransactionSecret` as response. With this, during the signing phase, the participant can decrypt the `EncryptedUnsignedCoinJoin` to sign it. This ensures only the participants of a round learn the CoinJoin before it is broadcast. This feature is not strictly necessary. | |
| When a participant registers an output, the coordinator gives an `UnsignedTransactionSecret` as response. With this, during the signing phase, the participant can decrypt the `EncryptedUnsignedCoinJoin` to sign it. This ensures only the participants of a round learn about the coinjoin before it is broadcast. This feature is not strictly necessary. |
BTCparadigm
reviewed
Oct 15, 2022
nopara73
suggested changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.