[Fluent] Source generators update #5522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this obsoleted by #5430? |
No. This is not related. This PR updates source generators packages and API usage to latest version. More work to be done here. |
|
For reference I am following patterns used in official samples updates from dotnet/roslyn-sdk#739 |
|
What's up here? Is this ready for review? |
No ready for review, a more work needed to finish. |
|
👀 |
|
PR is ready for review. |
danwalmsley
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #5417
TODO
Reference
Changes
The biggest change is switch to new
ISyntaxContextReceiverso the candidate symbols are filtered before processing using syntax receiver (this is simplest and fastest way to filter). TheOnVisitSyntaxNodecontext has access toSemanticModelso we can resolve candidates and filter them using e.g. attributes to some other desired pattern (e.g. ViewModel suffix).Second change is the that generated attributes (via. AddSource) are added in
Initializemethod instead ofExecuteand this simplifies processing isExecutemethod.Also above two changes simplify how we retrieve compilation from
GeneratorExecutionContextcontext (the RegisterForPostInitialization adds code to compilation before the syntax nodes are visited using SyntaxReceiver).Set IsRoslynComponent=true in generator project (VS capability that indicates that project supports component debugging).
Removed PropertyGenerator as we only use AutoNotifyGenerator.