Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY : format_tools - alternative API function #1496

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

InAnYan
Copy link

@InAnYan InAnYan commented Nov 19, 2024

No description provided.

@InAnYan InAnYan changed the title Continue to work on READY : format_tools - alternative API function Nov 19, 2024
column_names : Vec< Cow< 'data, str > >,
has_header : bool,
rows : Vec< Vec< Cow< 'data, str > > >,
filter_col : &'context ( dyn FilterCol + 'context ),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not it part of context?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are part of Printer which is a part of Context.

I removed these fields

@InAnYan InAnYan changed the title READY : format_tools - alternative API function NOT READY : format_tools - alternative API function Nov 22, 2024
@InAnYan InAnYan marked this pull request as draft November 22, 2024 08:04
@InAnYan InAnYan changed the title NOT READY : format_tools - alternative API function READY : format_tools - alternative API function Nov 22, 2024
@InAnYan InAnYan marked this pull request as ready for review November 22, 2024 08:45
@Wandalen Wandalen merged commit 3620512 into Wandalen:alpha Nov 22, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants