Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling merge queues #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enabling merge queues #140

wants to merge 1 commit into from

Conversation

faizanH
Copy link
Contributor

@faizanH faizanH commented May 9, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pic

Embed something funny here

@faizanH faizanH requested a review from a team as a code owner May 9, 2024 05:22

jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Path filtering
uses: dorny/paths-filter@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use a commit hash instead of a version, as for other uses lines


jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Path filtering
uses: dorny/paths-filter@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use a commit hash instead of a version, as for other uses lines

@@ -14,6 +13,15 @@ jobs:
NPM_VERSION: 10

steps:
- name: Path filtering
uses: dorny/paths-filter@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use a commit hash instead of a version, as for other uses lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants