Alts enhancements #2 #668
Open
Alts enhancements #2 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks alts whenever a player joins and sends a staff message when at least one muted or banned alt is found. A list of muted/banned alts can be seen when hovering over the message. Muted alts are marked yellow, banned ones are marked red. Bans color-override mutes just like in #651 This also marks online players green (overridden by active mutes and bans) in /alts and solves #589 completely except for showing the active punishment by hovering over a name in /alts.
|
Tested. |
draem
approved these changes
Jul 13, 2020
chatasma
approved these changes
Jul 13, 2020
|
While this PR works in essence, I'm afraid of the amount of stress this will put onto the backend. Players often join the server using different accounts which would result in many HTTP requests being sent on each player join. It's also not rare to find players with over 10 alts under the same IP. An alternative solution to this could be implementing an endpoint on the backend that returns all the necessary data in a single request, which wouldn't render this PR useless, just needing a few changes. |
|
+1 to reducing backend load |
Atdit
added a commit
to Atdit/TGM
that referenced
this pull request
Jan 28, 2021
Since recently, /punishments shows us a list of a user's punishments as well as all the punishments on his IP. This change made /alts mark alt account's names as yellow and red as well, while they might not be currently muted or banned, but have an alt which is. This pulll request changes the following: - Checks while iterating through the punishments of every alt, whether the punishment.getPunished() equals the alt name which is currently checked. If it does not, it continues with the next punishment. - Checks the same while iterating through the punishments in the /punishments command, and doesn't list those punishments if the view is restricted (user does not have "tgm.punish.list") - Checks for every alt in /alts if the player is online, and if so, marks the name green, just like in WarzoneMC#668. It is overwritten by active mutes and bans. Tested.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks alts whenever a player joins and sends a staff message when at least one muted or banned alt is found. A list of muted/banned alts can be seen when hovering over the message. Muted alts are marked yellow, banned ones are marked red.
Bans color-override mutes just like in #651
This also marks online players green (overridden by active mutes and bans) in /alts and solves #589 completely except for showing the active punishment by hovering over a name in /alts.