Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hcp_fix to support the MotionRegression=FALSE condition #157

Merged
merged 4 commits into from
Nov 11, 2019

Conversation

mharms
Copy link
Contributor

@mharms mharms commented Nov 8, 2019

With the forthcoming FIX version "1.06.12", we can now properly implement HP filtering in the MotionRegression=FALSE condition within single-run FIX. This PR checks for the FIX version, and calls fix appropriately based on the FIX version.

This should resolve #108.

@mharms mharms requested review from coalsont and glasserm November 8, 2019 16:17
@glasserm
Copy link
Contributor

glasserm commented Nov 9, 2019

Has this been tested using the new options?

@mharms
Copy link
Contributor Author

mharms commented Nov 11, 2019

Yes, both hp=-1 and hp=2000 run to completion with doMotionRegression=FALSE.

@glasserm
Copy link
Contributor

Does hp=0 work and do a detrend?

@mharms
Copy link
Contributor Author

mharms commented Nov 11, 2019

No, that's a completely separate issue. Support for hp=0 was not added, so the script still aborts if hp=0 is requested.

@glasserm
Copy link
Contributor

Is that worth doing too, or a bigger job?

@mharms
Copy link
Contributor Author

mharms commented Nov 11, 2019

It's worth doing, but it is also a bigger job that I'm not going to tackle right now. We would either need to: (1) Implement an fsl_glm detrending of the volume data in the hp=0 condition, or (2) accomplish the filtering using functionhighpassandvariancenormalize (i.e., as we do in hcp_fix_multi_run).

Copy link
Contributor

@glasserm glasserm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike

@glasserm glasserm merged commit 5e3f543 into Washington-University:master Nov 11, 2019
@mharms mharms deleted the enh_hcp_fix branch November 21, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hcp_fix doesn't apply any hp filter to CIFTI if do_motion_regression=FALSE
3 participants