-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hcp_fix to support the MotionRegression=FALSE condition #157
Conversation
Has this been tested using the new options? |
Yes, both hp=-1 and hp=2000 run to completion with doMotionRegression=FALSE. |
Does hp=0 work and do a detrend? |
No, that's a completely separate issue. Support for hp=0 was not added, so the script still aborts if hp=0 is requested. |
Is that worth doing too, or a bigger job? |
It's worth doing, but it is also a bigger job that I'm not going to tackle right now. We would either need to: (1) Implement an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike
With the forthcoming FIX version "1.06.12", we can now properly implement HP filtering in the MotionRegression=FALSE condition within single-run FIX. This PR checks for the FIX version, and calls
fix
appropriately based on the FIX version.This should resolve #108.