Pass on gpu options #193
Merged
Pass on gpu options #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves #189 |
glasserm
approved these changes
Aug 24, 2020
mharms
approved these changes
Aug 24, 2020
coalsont
reviewed
Aug 24, 2020
| @@ -379,7 +379,9 @@ get_options() { | |||
| echo " resamp_value: ${resamp_value}" | |||
| echo " ol_nstd_value: ${ol_nstd_value}" | |||
| echo " extra_eddy_args: ${extra_eddy_args}" | |||
| echo " no_gpu: ${no_gpu}" | |||
| if [ ! -z ${no_gpu} ]; then | |||
There was a problem hiding this comment.
I think our convention in other scripts is to print argument values even if they are empty or used the default.
There was a problem hiding this comment.
Ok, I've adjusted this to print all argument values. To make the printed output more meaningful I set the default value from no_gpu (and SelectBestB0) to false rather than an empty string.
mharms
reviewed
Aug 25, 2020
| @@ -223,7 +223,7 @@ get_options() { | |||
| resamp_value="" | |||
| unset ol_nstd_value | |||
| extra_eddy_args="" | |||
| no_gpu="" | |||
| no_gpu="False" | |||
There was a problem hiding this comment.
Our changing convention on the case across these scripts is annoying (False vs false vs FALSE), but I see that what you did in DiffPreprocPipeline_Eddy.sh is consistent with the rest of the script.
coalsont
reviewed
Aug 25, 2020
|
Is this ready now @coalsont ? |
coalsont
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes on the --no-gpu and --cuda-version flag from DiffPreprocPipeline.sh to DiffPreprocPipeline_Eddy.sh.
Also contains two other minor fixes: