-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generation of scene/snapshots for fMRIQC #203
Conversation
I think a few files use |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and thanks for making a no mask SBRef. I would like to look over some test results prior to approving.
With the above additions, this should now be operational. I'm running another test overnight (denovo execution of fMRIVolume and fMRISurface) and can generate a |
The code as it exists in this PR works. I'll email you the location of the scene file. |
@glasserm : It would be great if you can review the scene file. Would like to get this PR into the master, tag a new 4.3rc, and then have QuNex folks build a new container using that. |
I looked but did not find an e-mail from you showing the location of the scene file. |
@glasserm I sent the email again. |
@coalsont: Here's the
He confirmed that this does indeed catch the "error" when wb_command got killed due to insufficient memory. Although your coupling its placement to the debug.shlib line seems cleaner, if it doesn't need to be inside |
Just for public documentation purposes, the |
The |
Still need to revise and add the scene template itself, but wanted to get the code up for initial review.
Of note, the bias corrected, normalized, but not brain masked version of the scout is named with a "_notmasked" suffix currently. "unmasked" was a bit too cryptic in my opinion, although open to other suggestions.