Batch queue rework #239
Merged
Batch queue rework #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt Example Script Format *Only one mode of IcaFixProcessingBatch.sh active (MR fix default, SR fix commented out) *Remove duplicate Shebang
…ainingData to prevent errors
Added comments about HighPass for MR Fix data
Added note about RegName
Added note about space delimiting for fMRINames/ConcatName.
Added note on space delimiting for fMRINames/ConcatNames.
coalsont
commented
Nov 24, 2022
coalsont
commented
Nov 24, 2022
mharms
reviewed
Nov 26, 2022
mharms
reviewed
Nov 26, 2022
mharms
reviewed
Nov 26, 2022
glasserm
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
I think we should probably make a record keeping folder and move the 3T size checking and 7T examples there. I think they could be potentially confusing as it stands now. We should go ahead and get a release out with these changes and then work on getting legacy mode for sICA+FIX and the transmit field correction pipeline into the next release.
|
Is "historical" a good name for the record-keeping folder? |
|
Please check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
QUEUEvariable in all applicable example batch scripts to contain only the queue name without the-qflag (adding logic later on to do this for you), and an emptyQUEUEor specifying the--runlocaloption now both cause capturing of stdout/stderr to log files (via fsl_sub without-q).It also obsoletes
PRINTCOMin most launch scripts, as it was inconsistent and incomplete (the exception is Diffusion, where it was close to complete, and I added it to the few lines that were missing it), and adds some quoting.This branch was tested by Jenn, who also added some documentation updates.