Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rsn regression with the tICA regression #278

Merged
merged 7 commits into from
Nov 8, 2023
Merged

update rsn regression with the tICA regression #278

merged 7 commits into from
Nov 8, 2023

Conversation

cyang31
Copy link
Contributor

@cyang31 cyang31 commented Nov 4, 2023

Introduce a tICA_weighted mode which performs the following steps in one mode:

  • weighted spatial regression given a group sICA spatial map;
  • tICA unmix given a group tICA mixing matrix;
  • single regression to generate individual tICA spatial maps.

@cyang31 cyang31 requested review from coalsont and glasserm November 4, 2023 15:47
Copy link
Contributor

@glasserm glasserm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me.

@cyang31
Copy link
Contributor Author

cyang31 commented Nov 6, 2023

The code redundancy is mainly because I am too lazy to dig into the dimension and stuff so I keep the same workflow as in tICA/scripts/ComputeGroupTICA.sh. Now I remove the redundancy: 1) There's no need to check the zeros since this is an inference mode without padding. 2) No need to check the subject timepoints.

@cyang31
Copy link
Contributor Author

cyang31 commented Nov 6, 2023

The latest commit has been tested without error. The log file: /media/myelin/alex/pipelines/pipeline_areal_classifier/areal_classifier/twregression_log/RSNregression.sh.o1994865

@coalsont coalsont merged commit dfcec15 into Washington-University:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants