Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled reclean pipeline #281

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

cyang31
Copy link
Contributor

@cyang31 cyang31 commented Jan 19, 2024

The reclean pipeline with compiled feature generation step is added in this PR.

The test is still running. I will update with the test result soon.

Copy link
Contributor

@glasserm glasserm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is tested, we should merge so that Jure can test.

@coalsont
Copy link
Member

Merge comes after testing, not before. Jure should be able to test a branch on a different repo.

@cyang31
Copy link
Contributor Author

cyang31 commented Jan 19, 2024

If this is tested, we should merge so that Jure can test.

I will update in this thread if it fully passes the test. Currently, it has already passed the step of this new change (compiled feature generation script), but I haven't tested the rest of the compiled steps (FIX, etc.). It should work though, because the rest is simply FIX pipeline that has been tested.

@cyang31
Copy link
Contributor Author

cyang31 commented Jan 19, 2024

The current PR passed the test on my end.

@demsarjure demsarjure merged commit 4840256 into Washington-University:master Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants