fix: dark mode in useCDN case #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 , any thoughts about this PR? Any reaction would be nice, thank you. |
|
@sven-seyfert , thanks for raising the PR. Changes look good to me. I will check this tomorrow morning and will merge it if everything is working fine. |
WasiqB
approved these changes
Oct 1, 2024
|
🚀 This pull request is included in v3.8.0. See Release 3.8.0 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks 👋 ,
this should be a fix for #374 .
I added a test for the useCDN case and reviewed the report files manually after the creation.
Looks good to me, but please do a double check, thanks 🤝 .
I hope this fulfills your contribution guideline. If not, don't hesitate to tell me what I have to change.
Best regards
Sven