Add support for multiple screenshots in scenario steps #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be honest. I have no idea what the coverage/coveralls check is complaining about. |
|
Tnx man for the PR, I'll take a look at it tomorrow. Will also fix the css 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber allows saving of multiple images, but the report currently only displays the last image that was attached.
Updated the report to show all images attached to a step.
Note: I advise updating the css to better accommodate multiple images. Currently, small images will stretch to the width of the largest image - making them looked stretched, and it's hard to tell where an image ends and another stops. In the screenshots below, you'll see how it looks with my custom css that I feel best displays the images. I'll gladly give you the css if you're wanting to copy and use it.