Support for unescaped text/html embeds #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tnx for the PR I'm currently not available due to traveling and vacation. When I'm back I'll check and merge it. |
wswebcreation
approved these changes
Aug 17, 2018
yaronassa
added a commit
to yaronassa/multiple-cucumber-html-reporter
that referenced
this pull request
Sep 26, 2018
Update template condition to not suppress output for hidden steps w/ html embed
|
@wswebcreation Hey, just noticed a bug that didn't output html embeds for hidden steps (I missed a condition in the template when adding my original changes). |
|
Can you push that fix and create a PR for it? |
|
Yeah, sure, don't know why I pushed it here. |
|
No problem, will check it out later. Tnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the user to embed the
text/htmlmime type, and have the embed data displayed, unescaped, in the scenario report.The commit consists of 3 main changes:
text/htmlmime_type handler to the if structure in_parseSteps. I just collects the data into a.htmlproperty on the step..htmlproperty. It joins multiple attachments into a single HTML block, separated by a<br/>element.