Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llm inference docs #187

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update llm inference docs #187

merged 1 commit into from
Nov 6, 2023

Conversation

alabulei1
Copy link
Collaborator

fix the build errors

Copy link
Collaborator Author

alabulei1 commented Nov 6, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 7b602846faeae24d6100f68f07f3fb89fce2b2c9

Key changes in the patch:

  1. In the English version of the documentation:

    • The link to the Llama2 inference in Rust chapter has been updated to use the correct file name ("llm_inference" instead of "llm-inference").
    • Minor formatting changes have been made in the installation commands.
  2. In the Chinese version of the documentation:

    • The link to the Llama2 inference in Rust chapter has been updated to use the correct file name ("llm_inference" instead of "llm-inference").
    • Additional information has been added for the ggml-backend and its installation steps.

Potential problems:

  1. The links to the Llama2 inference in Rust chapter have been updated, but other chapters' links have not been checked for accuracy. It would be good to verify that all hyperlinks are correct.
  2. The formatting changes in the installation commands may introduce errors if not properly reviewed.
  3. In the Chinese version, there may be a typo in the heading "具有 TensorFlow-Lite 后端的 WASI-NN 插件" (third-level heading "带有 TensorFlow-Lite 后端的 WASI-NN 插件") where "后端" is repeated twice.
  4. The patch only includes changes to the documentation files, so it's unclear if any corresponding code changes were made to support these updates.

@hydai hydai merged commit e3811ce into main Nov 6, 2023
6 checks passed
@hydai hydai deleted the fix-build-error branch November 6, 2023 07:20
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 19, 2023
Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
alabulei1 added a commit that referenced this pull request Jan 25, 2024
* translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add zh-cn translation

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix: repo references

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* Signed-off-by: alabulei1 <vivian.xiage@gmail.com>

* Update llm inference docs (#187)

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>

* Update llm_inference.md

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>

* Update llm_inference.md

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>

* Update llm_inference.md

Signed-off-by: Michael Yuan <michael@michaelyuan.com>

* Update llm_inference.md

Signed-off-by: Michael Yuan <michael@michaelyuan.com>

* translate i18n/zh/docusaurus-plugin-content-docs/current/start/overview.md (#183)

* translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* Update overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

---------

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add missing links

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix links in plugins(zh)

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add missing links

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* doc: remove unnecessary space

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392653345

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392652961

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392647856

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392604553

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392650533

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392621661

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392632935

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix translations

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix rebase

Signed-off-by: ezirmusitua <jferroal@gmail.com>

---------

Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>
Signed-off-by: Michael Yuan <michael@michaelyuan.com>
Co-authored-by: alabulei1 <vivian.xiage@gmail.com>
Co-authored-by: Michael Yuan <michael@michaelyuan.com>
kelvinparmar pushed a commit to kelvinparmar/docs that referenced this pull request Feb 3, 2024
* translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add zh-cn translation

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix: repo references

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* Signed-off-by: alabulei1 <vivian.xiage@gmail.com>

* Update llm inference docs (WasmEdge#187)

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>

* Update llm_inference.md

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>

* Update llm_inference.md

Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>

* Update llm_inference.md

Signed-off-by: Michael Yuan <michael@michaelyuan.com>

* Update llm_inference.md

Signed-off-by: Michael Yuan <michael@michaelyuan.com>

* translate i18n/zh/docusaurus-plugin-content-docs/current/start/overview.md (WasmEdge#183)

* translate i18n/zh/docusaurus-plugin-content-docs/current/start/ overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* Update overview.md

Signed-off-by: ezirmusitua <jferroal@gmail.com>

---------

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add missing links

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix links in plugins(zh)

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* add missing links

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* doc: remove unnecessary space

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392653345

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392652961

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392647856

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392604553

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392650533

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392621661

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* apply suggestion https://github.com/WasmEdge/docs/pull/185\#discussion_r1392632935

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix translations

Signed-off-by: ezirmusitua <jferroal@gmail.com>

* fix rebase

Signed-off-by: ezirmusitua <jferroal@gmail.com>

---------

Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: alabulei1 <vivian.xiage@gmail.com>
Signed-off-by: Michael Yuan <michael@secondstate.io>
Signed-off-by: Michael Yuan <michael@michaelyuan.com>
Co-authored-by: alabulei1 <vivian.xiage@gmail.com>
Co-authored-by: Michael Yuan <michael@michaelyuan.com>
Signed-off-by: kelvin <pkelvin123456789@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants