-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build script #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit 5d7d6f878ddf0795ab9d2296c04bbc2bc0d362caKey Changes:
Potential Problems:
|
@apepkuss PTAL :-) |
apepkuss
reviewed
Jul 27, 2023
@jprendes This PR is a BIG STEP for the build script. Really thank you for your efforts. BTW, could this PR also fix #34? In this issue, @ipuustin mentions "proxy prison". Thanks. |
jprendes
force-pushed
the
refactor-build-script
branch
from
July 27, 2023 14:23
45d4065
to
a317f1c
Compare
I pushed a new version. To help with reproducible builds:
|
jprendes
force-pushed
the
refactor-build-script
branch
2 times, most recently
from
July 27, 2023 14:43
be7ae85
to
0a0c69b
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
refactor-build-script
branch
from
July 27, 2023 14:44
0a0c69b
to
5d7d6f8
Compare
apepkuss
approved these changes
Jul 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
wasmedge-sys
build script to remove the dependency on the external commandswget
,tar
andbash
.It also reduces the amount of duplicated code in the build script.
Fixes #30.
Fixes #34.