-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the version of wat
dep
#90
Conversation
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the Pull Request includes a variety of changes. Here are the most important findings:
Considering all the individual summaries, the most important finding is the potential compatibility issues that may arise from relaxing the version of the DetailsCommit 0c0632321494f2eee1d745b0cbfd11dc1c9c2dd7Key changes:
Potential problems:
Additional notes:
Commit eed350a0fc3872512c2427ee157b9c22ad875f78Key changes:
Potential problems:
Overall, the changes seem to be focused on improving the test code for the Rust SDK. However, without additional context or information, it is difficult to assess the impact and potential problems of these changes in the larger codebase. Commit fd2abf93bd054ef1201419cc28e05844d4f09184Summary of key changes:
Potential problems:
Commit 1cb5a1da951acbd7100de75e498a2868b44006bbKey changes:
Potential problems:
Overall, this patch appears to be a straightforward update to the Commit 01acb32aa97ba9772466a887edb1f682ed145308Key changes:
Potential problems:
Commit 2a177acc54b29c3f25dc961a4af1b9def1da20a9Key changes:
Potential problems:
|
@hydai Could you please help review this PR? Thanks a lot! |
@hydai Thanks for the review! |
* [Refactor] Add #[form] for subtypes of WasmEdgeError. Signed-off-by: csh <458761603@qq.com> * [Refactor] fix memory leak Signed-off-by: csh <458761603@qq.com> * [Fix] Avoid the CPU 100% by tokio-wasi. Signed-off-by: csh <458761603@qq.com> * [Fix] Fix blocking during tokio-wasi TCP connect. Signed-off-by: csh <458761603@qq.com> * [Fix] async-wasi get envs & args Signed-off-by: csh <458761603@qq.com> * [Perf] Optimize the wasi-ctx Signed-off-by: csh <458761603@qq.com> * [Chore] Temporarily disable the serialize feature. Signed-off-by: csh <458761603@qq.com> * [feat] virtual file system Signed-off-by: csh <458761603@qq.com> * [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76) * [Feat] run func timeout use std::time::Duration Signed-off-by: csh <458761603@qq.com> * [Doc]: update api docs Signed-off-by: csh <458761603@qq.com> --------- Signed-off-by: csh <458761603@qq.com> (cherry picked from commit 07e84b7) Signed-off-by: csh <458761603@qq.com> * [Refactor] delete useless code from validator Signed-off-by: csh <458761603@qq.com> * [Refactor] To pass the clippy Signed-off-by: csh <458761603@qq.com> * Disable timeout in musl libc (#71) Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> Signed-off-by: csh <458761603@qq.com> * Disable timeout in musl libc Signed-off-by: csh <458761603@qq.com> * [Doc] update doc Signed-off-by: csh <458761603@qq.com> * [Fix] fix ffi::WasmEdge_String to String Signed-off-by: csh <458761603@qq.com> * [Fix] Fix unit test Signed-off-by: csh <458761603@qq.com> * [Fix] Modify the `WasiModule`. Signed-off-by: csh <458761603@qq.com> * [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84) * feat(rust-sys): drop host_data in `Function::drop` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <sam@secondstate.io> * refactor(rust-sys): update `ImportModule::drop` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): remove debug code Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): remove debug code Signed-off-by: Xin Liu <sam@secondstate.io> * version(rust-sdk): bump to `0.13.0` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): supress clippy warning Signed-off-by: Xin Liu <sam@secondstate.io> * ci(ci-build): update rust version Signed-off-by: Xin Liu <sam@secondstate.io> * ci(standalone): update rust version Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update rustdoc and `README` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update dependencies Signed-off-by: Xin Liu <sam@secondstate.io> * ci: update to `macos-13` Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * doc: update `CHANGELOG` (#85) Signed-off-by: Xin Liu <sam@secondstate.io> * [Chore] Update build script (#86) * chore(rust-sys): update build script Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update build script Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * [Fix] Fix sys test Signed-off-by: csh <458761603@qq.com> * Relax the version of `wat` dep (#90) * chore(rust-sdk): update `wat` dep Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update test code Signed-off-by: Xin Liu <sam@secondstate.io> * version(rust-sys): bump to `0.17.4` Signed-off-by: Xin Liu <sam@secondstate.io> * version(rust-sdk): bump to `0.13.1` Signed-off-by: Xin Liu <sam@secondstate.io> * doc: update `CHANGELOG` Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * [CI] skip test_vmbuilder on fedora Signed-off-by: csh <458761603@qq.com> * Fix static build to link agains zstd (#91) Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> * Update doc for releasing `v0.13.2` (#93) * ci: update workflows Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): fix typo Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <sam@secondstate.io> * version(rust-sdk): bump to `0.13.2` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * [Version] Bump `wasmedge-sys` to `v0.17.5` (#94) * version(rust-sys): bump to `0.17.5` Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sys): update dependency Signed-off-by: Xin Liu <sam@secondstate.io> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * doc: update `CHANGELOG` (#95) Signed-off-by: Xin Liu <sam@secondstate.io> * [CI] Update `rust-static-lib` workflow (#96) * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <sam@secondstate.io> * ci(rust-static-lib): remove `libboost-all-dev` dep Signed-off-by: Xin Liu <sam@secondstate.io> --------- Signed-off-by: Xin Liu <sam@secondstate.io> * [Fix] Temporary FuncRef extraction implementation. Signed-off-by: csh <458761603@qq.com> * [CI] fix test wat Signed-off-by: csh <458761603@qq.com> --------- Signed-off-by: csh <458761603@qq.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> Signed-off-by: Xin Liu <sam@secondstate.io> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com> Co-authored-by: Xin Liu <sam@secondstate.io>
In this PR, relax the version of
wat
dep to fix #88. In addition, the test cases affected by the change also get updated.