feat: quest_shiny_probability

[Mygod]

Support for UnownHash/Golbat#267.

@jfberry @Fabio1988 I can't seem to find a quest with this field being nonzero though?

[Fabio1988]

They might add and remove that toggle from time to time.... It was present for gotour :)
Maybe they just need to send it during some certain events?

[jfberry]

Maybe we should not include it when it is 0? If that is what it looks like when empty

[Mygod]

It is indeed annoying. It looks like there isn't a way to distinguish missing ShinyProbability versus it being zero in the proto?

[github-actions]

🎉 This PR is included in version 1.36.0-develop.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[Mygod]

So i'm guessing that this is a shiny rate override option. If it's 0 then it's the global shiny rate that will be used instead.

[jfberry]

Or alternatively because they are paid for quests it may be ready to reveal odds under eu gambling laws

[Mygod]

Yes but they probably shouldn't only reveal it in a place that can only be seen through data mine?

[jfberry]

I’m thinking that this and other places (like eggs) which are related to purchases will start to comply with the law and show odds