Read gymBattles flag from Poracle and act accordingly #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires Poracle PR676, might work without it also Hides In battle switch from gym alarm selection and based on the value received alters the quick add gym alarm -functionality
|
Great PR! At first glance, my only ask, is that we wait to see if Jabes bumps the patch version as requested on PR 676, then we do so here as well during the version check step. I will test later today, thank you! |
- Remove unnecessary prop - Version check
|
@Ninjasoturi I added the version check and removed the unused prop added to the client settings, going to merge now. |
TurtIeSocks
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Poracle PR676, might work without it also, I didn't test it.
Hides In battle switch from gym alarm selection and based on the value received alters the quick add gym alarm -functionality.
I guess it's still possible for users to inject the
battle_changesflag from frontend, but that isn't a major concern.And again a warning, I still learning JS, so make sure this makes sense!