Poracle webhook search #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenisko
commented
Mar 28, 2022
- Move generating RM descriptions out of the tile to be able to search them - Remove some un-needed props in the tile now that the description is being generated outside - Memoize the profile filtering, the description generating, and the prop sorting - Then filter by search results - Minor adjustments to ReactWindow centering
Enable Searching for other categories since descriptions are more consistent now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic ability to search under Poracle webhook window.
It's looking inside descriptions for
'pokemon', 'raid', 'egg', 'gym'categories.Based on branch #432
I expect some request for changes :)