Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw NotFound when a poster image doesn't exist #52

Open
wants to merge 1 commit into
base: dev.waterwolf.club
Choose a base branch
from

Conversation

gmemstr
Copy link
Member

@gmemstr gmemstr commented Aug 23, 2024

No description provided.

@TapGhoul
Copy link

Do not merge this. You will break the poster prefabs. VRChat will not load anything unless it's 200/201/anything that's a valid response.
I tested with 204 no content, it will refuse to load even with that. Ergo, vrchat is handling status codes correctly - something we don't want.

If we plan to do a 404, we need to make a change in behavior to the system, including a not found image hard coded that we can't change. But as we don't really want to do that, you must return a 200 at all times.

I suggest, if you want to add tracing in the middle, you add an X-Inner-Status header or similar that you can trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants