Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: If a player doesn't get assigned to games, we can't collect their intro sequence data #898

Open
8 of 10 tasks
JamesPHoughton opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JamesPHoughton
Copy link
Collaborator

What happened?

If a player doesn't get assigned to a game, then we aren't getting their pre-survey data either, so we can't debug why they weren't assigned to a game.

This is probably because of the way we are collecting surveys:

// some intro surveys might go into the player record for future use?
    const surveys = filterByKey(player, game, (key) =>
      key.startsWith("survey_")
    );

If there is no game, an error is thrown, and nothing gets saved for that player

What browsers do you see the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge

What operating system do you see the problem on?

  • Windows
  • Mac
  • Linux

How did we discover the bug?

  • Reported by participant
  • Observed on Sentry
  • Found in dev

Priority

Inconvenience for researchers

@JamesPHoughton JamesPHoughton added the bug Something isn't working label Sep 26, 2024
JamesPHoughton added a commit that referenced this issue Sep 26, 2024
JamesPHoughton added a commit that referenced this issue Sep 26, 2024
JamesPHoughton added a commit that referenced this issue Sep 26, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection
JamesPHoughton added a commit that referenced this issue Oct 1, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection

* update countdown and lobby text

* add retry to localization

* Update 01_Normal_Paths_Omnibus.js

* Update Countdown.jsx
JamesPHoughton added a commit that referenced this issue Oct 1, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection

* update countdown and lobby text

* add retry to localization

* Update 01_Normal_Paths_Omnibus.js

* Update Countdown.jsx

* Fix repeated chime

* update timers for intro/exit

also fix direction of countdown offset
JamesPHoughton added a commit that referenced this issue Oct 2, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection

* update countdown and lobby text

* add retry to localization

* Update 01_Normal_Paths_Omnibus.js

* Update Countdown.jsx

* Fix repeated chime

* update timers for intro/exit

also fix direction of countdown offset

* Update GenericIntroExitStep.jsx
JamesPHoughton added a commit that referenced this issue Oct 2, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection

* update countdown and lobby text

* add retry to localization

* Update 01_Normal_Paths_Omnibus.js

* Update Countdown.jsx

* Fix repeated chime

* update timers for intro/exit

also fix direction of countdown offset

* Update GenericIntroExitStep.jsx

* update VPN check retries
JamesPHoughton added a commit that referenced this issue Oct 4, 2024
* update timings and templates

* fix tests

* add finalPayoffs to postflight report

* update tests

* test start and end timers

* fix data export when there is no game

Addresses #898

* fix data export when there is no game

Addresses #898

* skip qualtrics tests because of bot detection

* update countdown and lobby text

* add retry to localization

* Update 01_Normal_Paths_Omnibus.js

* Update Countdown.jsx

* Fix repeated chime

* update timers for intro/exit

also fix direction of countdown offset

* Update GenericIntroExitStep.jsx

* update VPN check retries

* improve player state logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant