update timings and templates #893

JamesPHoughton · 2024-09-16T19:24:08Z

No description provided.

github-actions · 2024-09-16T19:24:35Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/App.jsx
  170:7  error  Unknown property 'test-player-id' found  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   71:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  182:7  warning  Unexpected alert                                                                                                no-alert
  219:7  error    A control must be associated with a text label                                                                  jsx-a11y/control-has-associated-label

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  36:10  error  'state' is assigned a value but never used                                          no-unused-vars
  63:7   error  Invalid property 'scrolling' found on tag 'div', but it is only allowed on: iframe  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  125:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  306:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  477:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.test.js
  394:7  error  Identifier 'test_large_dispatch' is not in camel case  camelcase
  433:9  error  'assignments' is assigned a value but never used       no-unused-vars

✖ 26 problems (15 errors, 11 warnings)

cypress · 2024-09-16T19:40:22Z

Deliberation Run #1477

Run Properties: Passed #1477 • 432ce2a0fb: update tests

Project	`Deliberation`
Branch Review	`james-update-timings`
Run status	`Passed #1477`
Run duration	`11m 22s`
Commit	`432ce2a0fb: update tests`
Committer	`James Houghton`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`17`
View all changes introduced in this branch ↗︎

github-actions · 2024-09-16T20:11:51Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/App.jsx
  170:7  error  Unknown property 'test-player-id' found  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   71:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  182:7  warning  Unexpected alert                                                                                                no-alert
  219:7  error    A control must be associated with a text label                                                                  jsx-a11y/control-has-associated-label

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  36:10  error  'state' is assigned a value but never used                                          no-unused-vars
  63:7   error  Invalid property 'scrolling' found on tag 'div', but it is only allowed on: iframe  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  125:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  306:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  477:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.test.js
  394:7  error  Identifier 'test_large_dispatch' is not in camel case  camelcase
  433:9  error  'assignments' is assigned a value but never used       no-unused-vars

✖ 26 problems (15 errors, 11 warnings)

github-actions · 2024-09-17T14:22:17Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/App.jsx
  170:7  error  Unknown property 'test-player-id' found  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   71:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  182:7  warning  Unexpected alert                                                                                                no-alert
  219:7  error    A control must be associated with a text label                                                                  jsx-a11y/control-has-associated-label

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  36:10  error  'state' is assigned a value but never used                                          no-unused-vars
  63:7   error  Invalid property 'scrolling' found on tag 'div', but it is only allowed on: iframe  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  125:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  306:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  477:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.test.js
  394:7  error  Identifier 'test_large_dispatch' is not in camel case  camelcase
  433:9  error  'assignments' is assigned a value but never used       no-unused-vars

✖ 26 problems (15 errors, 11 warnings)

github-actions · 2024-09-17T14:36:45Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/App.jsx
  170:7  error  Unknown property 'test-player-id' found  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   71:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  182:7  warning  Unexpected alert                                                                                                no-alert
  219:7  error    A control must be associated with a text label                                                                  jsx-a11y/control-has-associated-label

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  36:10  error  'state' is assigned a value but never used                                          no-unused-vars
  63:7   error  Invalid property 'scrolling' found on tag 'div', but it is only allowed on: iframe  react/no-unknown-property

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  125:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  306:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  477:9  error  Unexpected use of continue statement  no-continue

✖ 23 problems (13 errors, 10 warnings)

sentry-io · 2024-09-26T21:42:50Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: Cannot read properties of undefined (reading 'get') SubmitButton(src/elements/SubmitButton) View Issue

_{Did you find this useful? React with a 👍 or 👎}

update timings and templates

197cedc

fix tests

6e6bfe2

add finalPayoffs to postflight report

353a4f0

update tests

432ce2a

JamesPHoughton merged commit d4126fe into main Sep 17, 2024
5 checks passed

JamesPHoughton deleted the james-update-timings branch September 17, 2024 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update timings and templates #893

update timings and templates #893

JamesPHoughton commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

cypress bot commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sentry-io bot commented Sep 26, 2024

update timings and templates #893

update timings and templates #893

Conversation

JamesPHoughton commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

cypress bot commented Sep 16, 2024 • edited Loading

Deliberation Run #1477

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sentry-io bot commented Sep 26, 2024

Suspect Issues

cypress bot commented Sep 16, 2024 •

edited

Loading