Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Dependency of FeatureBuilder on having "chat" or "turn" in the input path name. #211

Closed
xehu opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@xehu
Copy link
Collaborator

xehu commented Apr 29, 2024

Currently, the FeatureBuilder (feature_builder.py) assumes that we are passing in an output file path that contains either "chat" or "turn" in the name, as it saves the featurized content into either a "chat" folder or "turn" folder based on user
specifications.

Relevant code:

        self.output_file_path_chat_level = re.sub('chat', 'turn', output_file_path_chat_level) if self.turns else output_file_path_chat_level
        base_file_name = self.output_file_path_chat_level.split("/")[-1]
        self.vect_path = vector_directory + "sentence/" + ("turns" if self.turns else "chats") + "/" + base_file_name
        self.bert_path = vector_directory + "sentiment/" + ("turns" if self.turns else "chats") + "/" + base_file_name

We should think carefully about this design decision. Can we make the FeatureBuilder robust to output paths that do not have this in the path name? Or, if we absolutely require the output path to have the right keywords in it, can we add error checking and documentation so that when we fail, we fail noisily?

@xehu xehu added the enhancement New feature or request label Apr 29, 2024
@xehu xehu added this to the Release V1 of Team Process Mapping Package milestone Apr 29, 2024
@xehu xehu self-assigned this Jul 9, 2024
xehu added a commit that referenced this issue Jul 9, 2024
xehu added a commit that referenced this issue Jul 9, 2024
@xehu xehu closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant