Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 and console.log() #56

Closed
siamkreative opened this issue Jun 16, 2014 · 8 comments
Closed

IE11 and console.log() #56

siamkreative opened this issue Jun 16, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@siamkreative
Copy link

Hello there,

In one of our WordPress plugins, we use bootstrap3-wysihtml5.all.min.js.

Because of a console.log(); in this file, the javascript was not executed. Please see this comment on StackOverFlow.

Could you remove the console.log() or make sure it works on IE?

Cheers

@Waxolunist
Copy link
Owner

The console log comes from a dependency. I will see, what I can do. Either I can remove it upon build or add a wrapper.

@Waxolunist Waxolunist added the bug label Jun 16, 2014
@Waxolunist Waxolunist self-assigned this Jun 16, 2014
Waxolunist added a commit that referenced this issue Jun 16, 2014
option to build in order to remove console.log statements
@Waxolunist Waxolunist added this to the v0.3.2 (current development) milestone Jun 16, 2014
@Waxolunist
Copy link
Owner

Are you on the 0.3.x branch?
I just committed a fixed version. I don't have IE11 at hand. Can you confirm that it is working by using the current 0.3.0-wip branch? If you are using bower, changing the version should fix it.
If so, I will release two tags, one for the 0.2.x and one for the 0.3.x version, because this is a blocker.

BTW: Is your wordpress plugin open source or public? If so, I would like to link it.

@Waxolunist
Copy link
Owner

I just tested the release 0.3.1 on a vm with Windows 8.1 and IE 11 but I can not reproduce your problem. How can I reproduce your issue?

@siamkreative
Copy link
Author

Thanks for getting back to me. Unfortunately our plugin is a premium plugin. It uses version 0.2.10-alpha.2. Lemme try with the WIP version.

@Waxolunist
Copy link
Owner

I really suggest using the newest 0.3.x versions because 0.2.x depends on a wysihtml editor repo not maintained anymore.

I tested the 0.2.x branch with console.log and can not reproduce your issue. But I will remove it upon build also in the next 0.2.x release. I just pushed the fix to master. If you can confirm that it is working, I will make an release.

I would like to link your company from my repo in a "Used by" section if this is ok for you. I'd appreciate, if you write a short 1-2 sentence teaser for this section.

@Waxolunist Waxolunist reopened this Jun 17, 2014
@siamkreative
Copy link
Author

Sure, the WordPress plugin is Awesome Support and our brand is ThemeAvenue :)

I haven't tried the newest 0.3.x version yet. Using Bower, do you know how to specify the dev branch?

Cheers

@Waxolunist
Copy link
Owner

Just specify 0.3.0-wip as version.
Or for the 0.2.x "master".

see here http://stackoverflow.com/questions/15774649/specifying-latest-revision-of-a-particular-branch-with-bower

PS: Thx for the links.
BTW: If you are using FontAwesome: 0.3.1 has support for it.

@Waxolunist
Copy link
Owner

Ok, I will release with the fix this weekend in both branches. Thus I am closing. If you still got problems after the next release, please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants